1. 07 Aug, 2023 2 commits
    • dima.avdeev's avatar
      Remove old TODO comment (#782) · e35c9362
      dima.avdeev authored
      e35c9362
    • Elijah Semyonov's avatar
      Fix MetalRedrawer being a source of leak (#771) · ee58078e
      Elijah Semyonov authored
      * Break strong cycle
      
      * Add test proving it
      
      * Remove dead code
      
      * Explain test
      
      * Add remark about two passes
      
      * Add temporary ignore on test
      
      * Use assertTrue instead of assertEquals
      
      * Update test to ignore CI failure on Metal not supported
      
      * Update test
      
      * Refactor to reflect insight about memory model
      
      * Add contract comment.
      
      * Break strong reference from CADisplayLink -> MetalRedrawer
      
      * Bind logical lifetime of MetalRedrawer to caDisplayLink
      
      * Bind logical lifetime of MetalRedrawer to caDisplayLink
      
      * Close skia context on MetalRedrawer dispose.
      
      * Use `check`
      
      * Fix tests on iOS with Metal on GitHub Actions (#783)
      
      * iOS simulator warmup
      
      * comment redundant for now
      
      * sim ID
      
      * iPhone 8
      
      * iPhone 14
      
      * env.IOS_SIM_UUID
      
      * remove redundant
      
      * one line cmd
      
      * one line cmd
      
      * device
      
      * device
      
      * property
      
      * retry 3 times
      
      * retry 3 times
      
      * retry 5 times
      
      * retry 10 times
      
      * testMetalIosX64
      
      * test test fails
      
      * kotlin 1.8.20
      
      * success test
      
      * success test
      
      * temp fail
      
      * success test
      
      * simplify
      
      * simplify
      
      * simplify
      
      * Added iOS Metal tests only on MacOS
      
      * Gradle, check targets before adding iosX64TestWithMetal task
      
      ---------
      Co-authored-by: 's avatardima.avdeev <dima.avdeev@jetbrains.com>
      ee58078e
  2. 03 Aug, 2023 1 commit
    • Elijah Semyonov's avatar
      Refactoring pass for iOS counterpart of Skiko (#781) · 163aec11
      Elijah Semyonov authored
      * Refactor SkikoUIView and Metal interaction
      
      * Move load logic to init
      
      * Remove dead code
      
      * Use contentScaleFactor for calculating drawable size
      
      * Move UITouch.isPressed to filescope
      
      * Add trace logs for anomaly situations
      163aec11
  3. 31 Jul, 2023 3 commits
  4. 26 Jul, 2023 1 commit
  5. 24 Jul, 2023 1 commit
    • Elijah Semyonov's avatar
      Prevent needRedraw reentry on iOS (#769) · 68677fd5
      Elijah Semyonov authored
      * Move flush to `finally` block.
      
      * Prevent reentry when scene is invalidated within draw.
      
      * Revert "Move flush to `finally` block."
      
      This reverts commit 25b04b811c2425c27a04b7508dbd7de70b8ef735.
      
      * Prevent within frameListener as well.
      68677fd5
  6. 21 Jul, 2023 2 commits
  7. 19 Jul, 2023 1 commit
  8. 18 Jul, 2023 2 commits
  9. 10 Jul, 2023 1 commit
  10. 07 Jul, 2023 1 commit
  11. 06 Jul, 2023 4 commits
  12. 05 Jul, 2023 2 commits
  13. 04 Jul, 2023 1 commit
  14. 30 Jun, 2023 2 commits
    • Oleksandr Karpovich's avatar
      Implement hostOs detection for web target (#738) · 52c586f9
      Oleksandr Karpovich authored
      * Implement hostOs detection for web target
      
      * Refactor hostOs initialization in OsArch.js.kt
      
      Instead of using a lazy initialization, this change allows immediate initialization.
      
      * Deprecate incorrect enum OS.JS value in OsArch.kt
      
      Deprecation annotation has been added to JS enum in OsArch. This is done as 'JS' is not a valid host OS name. Added 'Unknown' enum for undefined or unknown cases to handle from now on. Consider using enum 'KotlinBackend' to detect JS.
      
      * Deprecate invalid Arch values and modify hostArch
      
      The Arch values 'JS' and 'WASM' were deprecated as they were found to be invalid. An 'Unknown' value was introduced to accommodate for unforeseen cases in the future. The 'hostArch' value under 'OsArch.js.kt' has been updated accordingly to use this new 'Unknown' value.
      
      * Add OS.Unknown to `when` expressions to make them exhaustive
      52c586f9
    • Nikolai Rykunov's avatar
  15. 29 Jun, 2023 4 commits
  16. 28 Jun, 2023 1 commit
  17. 26 Jun, 2023 4 commits
    • Igor Demin's avatar
      Refactorings from the AWT Font PR (#729) · e3b0ef8d
      Igor Demin authored
      * Refactoring from AWT Font PR
      
      Thanks, @rock3r, for refactorings! I extracted them from the AWT font PR (they were reverted in https://github.com/JetBrains/skiko/pull/639/commits/53f00c7d6be5ac0834ba4b4c3b9b4e3ea5cb0f10)
      
      - fix formatting
      - fix comments
      - split CI steps
      
      I am not sure about mikepenz/action-junit-report. Let's remove it for now (otherwise it should be investigated from functionality and security perspective)
      
      * Refactoring from AWT Font PR
      
      Thanks, @rock3r, for refactorings! I extracted them from the AWT font PR (they were reverted in https://github.com/JetBrains/skiko/pull/639/commits/53f00c7d6be5ac0834ba4b4c3b9b4e3ea5cb0f10)
      
      - fix formatting
      - fix comments
      - split CI steps
      
      I am not sure about mikepenz/action-junit-report. Let's remove it for now (otherwise it should be investigated from functionality and security perspective)
      
      Also, removed implementation("pl.pragmatists:JUnitParams:1.1.1"), as it isn't used.
      e3b0ef8d
    • Ivan Matkov's avatar
    • Ivan Matkov's avatar
      Set framebufferOnly = false (#728) · aa7e1bf7
      Ivan Matkov authored
      aa7e1bf7
    • Sebastiano Poggi's avatar
      Switch AWT font loading to Skia-based (#639) · 8e62cef3
      Sebastiano Poggi authored
      ## Improve font loading and listing
      Available font listing doesn't rely anymore on discovering and loading font files from the disk. This is MUCH faster than the previous solution, which could take seconds on a performant machine. Besides, this greatly reduces memory usage as we're only holding the font family names list in memory, and cache items in memory lazily only once they are requested to speed up later lookups. Users can manually clear the memory cache, and register custom fonts (from files or resources).
      
      We now get the list of available font families directly from Skia, with some additional features such as adding entries for the system font on macOS (which is hidden by default).
      
      To note, the list of fonts available to Skia is not the same as available to AWT, for a number of reasons:
       1. AWT adds logical fonts (e.g., `Dialog`)
       2. AWT silently substitutes broken fonts
       3. AWT lists the macOS system font, but under a weird name, `.AppleSystemUIFont`, whereas Skia doesn't
       4. AWT and Skia don't use the same logic to list installed fonts on all platforms
       5. AWT includes fonts embedded into the JVM automatically
      
      This makes things a bit more complicated, but if you _know_ the correct family name, everything works fine. While AWT silently substitutes invalid font family names with others, Skia will return `null` if it can't find a font. We follow the Skia approach, returning null if we can't match a font family name.
      
      ## Improve AWT `Font` conversion to Skiko `Typeface`
      On the JetBrains Runtime, the `Font.toSkikoTypefaceOrNull()` will be able to properly match an AWT `Font` to a Skiko `Typeface`, even on OSes other than macOS. If running on other JVMs, this returns `null`, as requested by @igordmn. This requirement is documented in the KDocs.
      
      The necessity to be on the JBR is due to the "regular" AWT implementations of `sun.font.Font2D` and `sun.funt.TrueTypeFont` being essentially broken: they read the wrong entry from the `name` table in TrueType fonts and use it as font family name. In the JBR, additional logic has been added to read the correct entry, the [_preferred family_](https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6name.html), and we can use this information to match with Skia font families, as Skia uses the correct _preferred family name_.
      8e62cef3
  18. 20 Jun, 2023 2 commits
  19. 05 Jun, 2023 2 commits
  20. 30 May, 2023 1 commit
  21. 26 May, 2023 1 commit
    • Elijah Semyonov's avatar
      iOS frames scheduling fix (#714) · 81f1a7ab
      Elijah Semyonov authored
      * Make rundown rendering bandaid(or not) fix to avoid incorrect scheduling problem
      
      * Remove unneeded counter check.
      
      * Extract magic value. Document it.
      
      * Remove bandaid.
      
      * Make right scheduling.
      
      * Fix for path on double-dispatch during vsync-frame.
      
      * Change logging a bit.
      
      * Update doc
      
      * Update doc
      
      * Add comment on touchesCount, rephrase the body.
      
      * Replace control flow with `also`
      
      * Remove debug logs.
      
      * Refactor 2 booleans into single enum.
      
      * Simplify enum
      
      * Replace Unit with empty body in `when` expressions.
      
      * Replace comment style in function scopes.
      
      * Make DrawSchedulingState private.
      
      * Change comment style on private property.
      
      * Add rationale behind drawSchedulingState initial value.
      81f1a7ab
  22. 17 May, 2023 1 commit