1. 01 Nov, 2024 1 commit
  2. 31 Oct, 2024 1 commit
  3. 29 Oct, 2024 1 commit
  4. 22 Oct, 2024 1 commit
  5. 18 Oct, 2024 1 commit
  6. 25 Sep, 2024 2 commits
  7. 18 Sep, 2024 2 commits
  8. 17 Sep, 2024 1 commit
  9. 09 Sep, 2024 1 commit
  10. 16 Aug, 2024 1 commit
  11. 14 Aug, 2024 1 commit
  12. 12 Aug, 2024 2 commits
  13. 07 Aug, 2024 1 commit
  14. 05 Aug, 2024 1 commit
    • Oleksandr Karpovich's avatar
      Fix skia download destination directory (#971) · c1f81974
      Oleksandr Karpovich authored
      The download directory path now depends on the buildType: Debug and
      Release
      
      
      ___
      It affected our buildServer CI pipeline where it builds Release first
      and then Debug. And downloadTask was considered UP-TO-DATE when Debug
      build was attempted. Therefore the build used "Release" version of skia
      instead of "Debug. "
      
      Added a Debug build to the githiub workflow too.
      c1f81974
  15. 02 Aug, 2024 1 commit
  16. 30 Jul, 2024 1 commit
  17. 23 Jul, 2024 2 commits
  18. 10 Jul, 2024 1 commit
  19. 09 Jul, 2024 3 commits
  20. 19 Jun, 2024 1 commit
  21. 13 Jun, 2024 1 commit
  22. 12 Jun, 2024 2 commits
  23. 11 Jun, 2024 2 commits
  24. 10 Jun, 2024 1 commit
  25. 28 May, 2024 1 commit
  26. 27 May, 2024 1 commit
  27. 21 May, 2024 2 commits
  28. 09 May, 2024 1 commit
  29. 26 Apr, 2024 1 commit
    • Elijah Semyonov's avatar
      Fix crash when creating SwingRedrawer on DirectX (#917) · 57dea506
      Elijah Semyonov authored
      ### Changes
      Throw `RenderException` when constructing `Direct3DSwingRedrawer` with
      `nullptr` device. (Similar to `Direct3DRedrawer`)
      
      To avoid crash in:
      ```
      DirectXOffscreenDevice *d3dDevice = fromJavaPointer<DirectXOffscreenDevice *>(devicePtr);
      GrD3DBackendContext backendContext = d3dDevice->backendContext;
      return toJavaPointer(GrDirectContext::MakeDirect3D(backendContext).release());
      ```
      
      ### Fixes
      
      Speculative fix for crash with a stack head below:
      ```
      ---------------  T H R E A D  ---------------
      
      Current thread (0x000001cbcb0793f0):  JavaThread "AWT-EventQueue-0" [_thread_in_native, id=16744, stack(0x0000009488c00000,0x0000009488d00000)]
      
      Stack: [0x0000009488c00000,0x0000009488d00000],  sp=0x0000009488cfc670,  free space=1009k
      Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
      C  [skiko-windows-x64.dll+0x58afa]
      
      Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)
      j  org.jetbrains.skiko.swing.Direct3DSwingRedrawer.makeDirectXContext(J)J+0
      ```
      
      ### Note
      I've found suspicious place in
      ```kotlin
      // RedrawManager.kt:30
      _renderApi = fallbackRenderApiQueue.removeAt(0)
      _redrawer = redrawerFactory(_renderApi, redrawer)
      ```
      Seems like `redrawer` is disposed twice if `redrawerFactory` throws
      (both paths constructing `RedrawerManager` are affected).
      
      @igordmn can you have a look?
      It's a universal path for all desktop users, so I wonder why it didn't
      backfire, if it's indeed incorrect.
      May be it's because we don't really call `redrawerFactory` if a redrawer
      was constructed correctly, so disposal of old one doesn't ever get
      called in this context. I'm not sure where are the invariant boundaries
      here.
      57dea506
  30. 18 Apr, 2024 1 commit
  31. 17 Apr, 2024 1 commit