Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
S
skiko
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
liuqiang
skiko
Commits
575edff1
Unverified
Commit
575edff1
authored
Oct 11, 2021
by
Roman Sedaikin
Committed by
GitHub
Oct 11, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix case when DirectSoftware on linux [getSurface] could throw [Can't wrap nullptr] (#253)
parent
375a3792
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
21 additions
and
4 deletions
+21
-4
SoftwareRedrawer.cc
skiko/src/jvmMain/cpp/linux/SoftwareRedrawer.cc
+8
-1
AbstractDirectSoftwareRedrawer.kt
...etbrains/skiko/redrawer/AbstractDirectSoftwareRedrawer.kt
+8
-1
LinuxSoftwareRedrawer.kt
...lin/org/jetbrains/skiko/redrawer/LinuxSoftwareRedrawer.kt
+5
-2
No files found.
skiko/src/jvmMain/cpp/linux/SoftwareRedrawer.cc
View file @
575edff1
...
...
@@ -46,7 +46,7 @@ public:
extern
"C"
{
JNIEXPORT
jlong
JNICALL
Java_org_jetbrains_skiko_redrawer_LinuxSoftwareRedrawer_createDevice
(
JNIEnv
*
env
,
jobject
redrawer
,
jlong
displayPtr
,
jlong
windowPtr
)
JNIEnv
*
env
,
jobject
redrawer
,
jlong
displayPtr
,
jlong
windowPtr
,
jint
width
,
jint
height
)
{
Display
*
display
=
fromJavaPointer
<
Display
*>
(
displayPtr
);
Window
window
=
fromJavaPointer
<
Window
>
(
windowPtr
);
...
...
@@ -59,6 +59,13 @@ extern "C"
{
return
0L
;
}
device
->
surface
.
reset
();
SkImageInfo
info
=
SkImageInfo
::
Make
(
width
,
height
,
device
->
colorSpace
,
kPremul_SkAlphaType
,
SkColorSpace
::
MakeSRGB
());
device
->
surface
=
SkSurface
::
MakeRaster
(
info
);
return
toJavaPointer
(
device
);
}
...
...
skiko/src/jvmMain/kotlin/org/jetbrains/skiko/redrawer/AbstractDirectSoftwareRedrawer.kt
View file @
575edff1
...
...
@@ -5,6 +5,7 @@ import kotlinx.coroutines.*
import
kotlinx.coroutines.swing.Swing
import
org.jetbrains.skiko.FrameDispatcher
import
org.jetbrains.skiko.FrameLimiter
import
org.jetbrains.skiko.RenderException
import
org.jetbrains.skiko.SkiaLayer
import
org.jetbrains.skiko.SkiaLayerProperties
...
...
@@ -37,7 +38,13 @@ internal abstract class AbstractDirectSoftwareRedrawer(
}
open
fun
resize
(
width
:
Int
,
height
:
Int
)
=
resize
(
device
,
width
,
height
)
fun
getSurface
()
=
Surface
(
getSurface
(
device
))
fun
getSurface
():
Surface
{
val
surface
=
getSurface
(
device
)
if
(
surface
==
0L
)
{
throw
RenderException
(
"Failed to create Surface"
)
}
return
Surface
(
surface
)
}
open
fun
finishFrame
()
=
finishFrame
(
device
)
override
fun
dispose
()
{
disposeDevice
(
device
)
...
...
skiko/src/jvmMain/kotlin/org/jetbrains/skiko/redrawer/LinuxSoftwareRedrawer.kt
View file @
575edff1
...
...
@@ -8,8 +8,11 @@ internal class LinuxSoftwareRedrawer(
)
:
AbstractDirectSoftwareRedrawer
(
layer
,
properties
)
{
init
{
val
scale
=
layer
.
contentScale
val
w
=
(
layer
.
width
*
scale
).
toInt
().
coerceAtLeast
(
0
)
val
h
=
(
layer
.
height
*
scale
).
toInt
().
coerceAtLeast
(
0
)
layer
.
backedLayer
.
lockLinuxDrawingSurface
{
device
=
createDevice
(
it
.
display
,
it
.
window
).
also
{
device
=
createDevice
(
it
.
display
,
it
.
window
,
w
,
h
).
also
{
if
(
it
==
0L
)
{
throw
RenderException
(
"Failed to create Software device"
)
}
...
...
@@ -29,5 +32,5 @@ internal class LinuxSoftwareRedrawer(
super
.
finishFrame
()
}
private
external
fun
createDevice
(
display
:
Long
,
window
:
Long
):
Long
private
external
fun
createDevice
(
display
:
Long
,
window
:
Long
,
width
:
Int
,
height
:
Int
):
Long
}
\ No newline at end of file
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment