• Aurelio Jargas's avatar
    github-cli: Remove duplicated find_version_from_git_tags () (#235) · 85d21509
    Aurelio Jargas authored
    This function was defined twice in the install script for GitHub CLI, in
    old lines 76 and 161. This commit removes the first definition.
    
    The only function calls were on old lines 201 and 222. Since they appear
    after the second function definition at line 161, the first one at line
    76 never got called, so it's safe to remove it.
    
    I confirmed that this was the only file in this repository where this
    function was duplicated:  
    
        $ git grep '^ *find_version_from_git_tags *('
        src/docker-from-docker/install.sh:find_version_from_git_tags() {
        src/docker-in-docker/install.sh:find_version_from_git_tags() {
        src/git-lfs/install.sh:find_version_from_git_tags() {
        src/github-cli/install.sh:find_version_from_git_tags() {
        src/github-cli/install.sh:find_version_from_git_tags() {
        src/go/install.sh:find_version_from_git_tags() {
        src/kubectl-helm-minikube/install.sh:find_version_from_git_tags() {
        src/php/install.sh:find_version_from_git_tags() {
        src/powershell/install.sh:find_version_from_git_tags() {
        src/python/install.sh:find_version_from_git_tags() {
        src/ruby/install.sh:find_version_from_git_tags() {
        src/rust/install.sh:find_version_from_git_tags() {
        src/terraform/install.sh:find_version_from_git_tags() {
        $
    85d21509
Name
Last commit
Last update
..
README.md Loading commit data...
devcontainer-feature.json Loading commit data...
install.sh Loading commit data...