Node: Fix bug - version set by Feature is not default (#294)

* Node:Fix bug version set by Feature is not default

* node not supported for ubuntu:bionic

src/node/devcontainer-feature.json

 {
     "id": "node",
-    "version": "1.1.1",
+    "version": "1.1.2",
     "name": "Node.js (via nvm) and yarn",
     "documentationURL": "https://github.com/devcontainers/features/tree/main/src/node",
     "description": "Installs Node.js, nvm, yarn, and needed dependencies.",

src/node/install.sh

@@ -81,6 +81,12 @@ check_packages() {
 # Ensure apt is in non-interactive to avoid prompts
 export DEBIAN_FRONTEND=noninteractive
 
+. /etc/os-release
+if [[ "bionic" = *"${VERSION_CODENAME}"* ]]; then
+    echo "(!) Unsupported distribution version '${VERSION_CODENAME}'. Details: https://github.com/nodejs/node/issues/42351#issuecomment-1068424442"
+    exit 1
+fi
+
 # Install dependencies
 check_packages apt-transport-https curl ca-certificates tar gnupg2 dirmngr
 
@@ -152,7 +158,7 @@ if [ ! -d "${NVM_DIR}" ]; then
 else
     echo "NVM already installed."
     if [ "${NODE_VERSION}" != "" ]; then
-        su ${USERNAME} -c "umask 0002 && . $NVM_DIR/nvm.sh && nvm install ${NODE_VERSION}"
+        su ${USERNAME} -c "umask 0002 && . $NVM_DIR/nvm.sh && nvm install ${NODE_VERSION} && nvm alias default ${NODE_VERSION}"
     fi
 fi
 

test/node/install_node_on_universal_image.sh

+#!/bin/bash
+
+set -e
+
+# Optional: Import test library
+source dev-container-features-test-lib
+
+check "version_on_path" bash -c "node -v | grep 'v19.1.0'"
+
+# Report result
+reportResults

test/node/scenarios.json

@@ -25,5 +25,14 @@
                 "version": "none"
             }
         }
+    },
+    "install_node_on_universal_image": {
+        "image": "mcr.microsoft.com/devcontainers/universal",
+        "remoteUser": "codespace",
+        "features": {
+            "node": {
+                "version": "19.1.0"
+            }
+        }
     }
 }
\ No newline at end of file