• Philipp Wagner's avatar
    Fix common-utils installation on RHEL (and friends) (#772) · def3a41f
    Philipp Wagner authored
    * Fix indentation in common-utils/main.sh
    
    * common-utils: Fix install error on RHEL
    
    On RHEL (and derivatives) the installation of the common-utils feature
    could fail if the feature ran before (i.e., `PACKAGES_ALREADY_INSTALLED`
    is set) and if either `INSTALL_ZSH` is false, or zsh was installed
    earlier and `ZSH_ALREADY_INSTALLED` is true.
    
    In these cases the script the `package_list` is empty, and `dnf`
    terminates with the following error message:
    
    ```
    usage: dnf install [-c [config file]] [-q] [-v] [--version]
                       [--installroot [path]] [--nodocs] [--noplugins]
                       [--enableplugin [plugin]] [--disableplugin [plugin]]
                       [--releasever RELEASEVER] [--setopt SETOPTS]
                       [--skip-broken] [-h] [--allowerasing] [-b | --nobest] [-C]
                       [-R [minutes]] [-d [debug level]] [--debugsolver]
                       [--showduplicates] [-e ERRORLEVEL] [--obsoletes]
                       [--rpmverbosity [debug level name]] [-y] [--assumeno]
                       [--enablerepo [repo]] [--disablerepo [repo] | --repo
                       [repo]] [--enable | --disable] [-x [package]]
                       [--disableexcludes [repo]] [--repofrompath [repo,path]]
                       [--noautoremove] [--nogpgcheck] [--color COLOR] [--refresh]
                       [-4] [-6] [--destdir DESTDIR] [--downloadonly]
                       [--comment COMMENT] [--bugfix] [--enhancement]
                       [--newpackage] [--security] [--advisory ADVISORY]
                       [--bz BUGZILLA] [--cve CVES]
                       [--sec-severity {Critical,Important,Moderate,Low}]
                       [--forcearch ARCH]
                       PACKAGE [PACKAGE ...]
    dnf install: error: the following arguments are required: PACKAGE
    ```
    
    Fix the problem by running `dnf` only with a non-zero `package_list`.
    def3a41f
main.sh 21 KB