Commit e4cf4694 authored by Alexey Tsvetkov's avatar Alexey Tsvetkov

Fix task naming and formatting

parent 22faede5
...@@ -132,7 +132,7 @@ if (supportWasm) { ...@@ -132,7 +132,7 @@ if (supportWasm) {
fun compileNativeBridgesTask(os: OS, arch: Arch): TaskProvider<CompileSkikoCppTask> { fun compileNativeBridgesTask(os: OS, arch: Arch): TaskProvider<CompileSkikoCppTask> {
val skiaNativeDir = registerOrGetSkiaDirProvider(os, arch) val skiaNativeDir = registerOrGetSkiaDirProvider(os, arch)
return tasks.register<CompileSkikoCppTask>("${os.id}_${arch.id}_CrossCompile") { return project.registerSkikoTask<CompileSkikoCppTask>("compileNativeBridges", os, arch) {
dependsOn(skiaNativeDir) dependsOn(skiaNativeDir)
val unpackedSkia = skiaNativeDir.get() val unpackedSkia = skiaNativeDir.get()
...@@ -461,7 +461,7 @@ fun configureNativeTarget(os: OS, arch: Arch, target: KotlinNativeTarget) { ...@@ -461,7 +461,7 @@ fun configureNativeTarget(os: OS, arch: Arch, target: KotlinNativeTarget) {
val crossCompileTask = compileNativeBridgesTask(os, arch) val crossCompileTask = compileNativeBridgesTask(os, arch)
val linkTask = project.tasks.register<Exec>("linkNativeBridges$targetString") { val linkTask = project.registerSkikoTask<Exec>("linkNativeBridges", targetOs, targetArch) {
dependsOn(crossCompileTask) dependsOn(crossCompileTask)
val objectFilesDir = crossCompileTask.map { it.outDir.get() } val objectFilesDir = crossCompileTask.map { it.outDir.get() }
val objectFiles = project.fileTree(objectFilesDir) { val objectFiles = project.fileTree(objectFilesDir) {
...@@ -621,8 +621,11 @@ fun androidJar(version: String = "30"): String { ...@@ -621,8 +621,11 @@ fun androidJar(version: String = "30"): String {
return androidHome.resolve("platforms/android-$version/android.jar").absolutePath return androidHome.resolve("platforms/android-$version/android.jar").absolutePath
} }
fun createCompileJvmBindingsTask(targetOs: OS, targetArch: Arch, skiaJvmBindingsDir: Provider<File>) = fun createCompileJvmBindingsTask(
tasks.register<CompileSkikoCppTask>("compileJvmBindings-${targetOs.id}-${targetArch.id}") { targetOs: OS,
targetArch: Arch,
skiaJvmBindingsDir: Provider<File>
) = project.registerSkikoTask<CompileSkikoCppTask>("compileJvmBindings", targetOs, targetArch) {
// Prefer 'java.home' system property to simplify overriding from Intellij. // Prefer 'java.home' system property to simplify overriding from Intellij.
// When used from command-line, it is effectively equal to JAVA_HOME. // When used from command-line, it is effectively equal to JAVA_HOME.
if (JavaVersion.current() < JavaVersion.VERSION_11) { if (JavaVersion.current() < JavaVersion.VERSION_11) {
...@@ -722,10 +725,12 @@ fun createCompileJvmBindingsTask(targetOs: OS, targetArch: Arch, skiaJvmBindings ...@@ -722,10 +725,12 @@ fun createCompileJvmBindingsTask(targetOs: OS, targetArch: Arch, skiaJvmBindings
) )
} }
fun createLinkJvmBindings(targetOs: OS, targetArch: Arch, fun createLinkJvmBindings(
targetOs: OS,
targetArch: Arch,
skiaJvmBindingsDir: Provider<File>, skiaJvmBindingsDir: Provider<File>,
compileTask: TaskProvider<CompileSkikoCppTask>) = compileTask: TaskProvider<CompileSkikoCppTask>
tasks.register<LinkSkikoTask>("linkJvmBindings-${targetOs.id}-${targetArch.id}") { ) = project.registerSkikoTask<LinkSkikoTask>("linkJvmBindings", targetOs, targetArch) {
val target = targetId(targetOs, targetArch) val target = targetId(targetOs, targetArch)
val skiaBinSubdir = "out/${buildType.id}-$target" val skiaBinSubdir = "out/${buildType.id}-$target"
val skiaBinDir = skiaJvmBindingsDir.get().absolutePath + "/" + skiaBinSubdir val skiaBinDir = skiaJvmBindingsDir.get().absolutePath + "/" + skiaBinSubdir
...@@ -949,9 +954,11 @@ fun skikoJvmRuntimeJarTask( ...@@ -949,9 +954,11 @@ fun skikoJvmRuntimeJarTask(
from(createChecksums.map { it.outputs.files }) from(createChecksums.map { it.outputs.files })
} }
fun skikoRuntimeDirForTestsTask(targetOs: OS, targetArch: Arch, fun skikoRuntimeDirForTestsTask(
skikoJvmRuntimeJar: Provider<Jar>) = targetOs: OS,
project.tasks.register<Copy>("skikoRuntimeDirForTests-${targetOs.id}-${targetArch.id}") { targetArch: Arch,
skikoJvmRuntimeJar: Provider<Jar>
) = project.registerSkikoTask<Copy>("skikoRuntimeDirForTests", targetOs, targetArch) {
dependsOn(skikoJvmRuntimeJar) dependsOn(skikoJvmRuntimeJar)
from(zipTree(skikoJvmRuntimeJar.flatMap { it.archiveFile })) { from(zipTree(skikoJvmRuntimeJar.flatMap { it.archiveFile })) {
include("*.so") include("*.so")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment