Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
S
skiko
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
liuqiang
skiko
Commits
e3e6430d
Unverified
Commit
e3e6430d
authored
Jan 05, 2026
by
Alexander Maryanovsky
Committed by
GitHub
Jan 05, 2026
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix `RefCnt.toString` to not crash after `_ptr` has been assigned null (#1142)
parent
797ec7b6
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
17 additions
and
12 deletions
+17
-12
RefCnt.kt
...o/src/commonMain/kotlin/org/jetbrains/skia/impl/RefCnt.kt
+14
-0
RefCnt.jvm.kt
.../src/jvmMain/kotlin/org/jetbrains/skia/impl/RefCnt.jvm.kt
+1
-4
RefCnt.native.kt
...ativeMain/kotlin/org/jetbrains/skia/impl/RefCnt.native.kt
+1
-4
RefCnt.js.kt
...o/src/webMain/kotlin/org/jetbrains/skia/impl/RefCnt.js.kt
+1
-4
No files found.
skiko/src/commonMain/kotlin/org/jetbrains/skia/impl/RefCnt.kt
View file @
e3e6430d
...
@@ -13,4 +13,18 @@ expect abstract class RefCnt : Managed {
...
@@ -13,4 +13,18 @@ expect abstract class RefCnt : Managed {
val
refCount
:
Int
val
refCount
:
Int
}
}
internal
fun
RefCnt
.
refCntToString
(
managedString
:
String
,
nullPointer
:
NativePointer
)
=
buildString
{
append
(
managedString
)
setLength
(
length
-
1
)
// remove trailing ')'
if
(
_ptr
==
nullPointer
)
{
append
(
", disposed"
)
}
else
{
append
(
", refCount="
)
append
(
refCount
)
}
append
(
')'
)
}
internal
expect
fun
RefCnt_nGetFinalizer
():
NativePointer
internal
expect
fun
RefCnt_nGetFinalizer
():
NativePointer
skiko/src/jvmMain/kotlin/org/jetbrains/skia/impl/RefCnt.jvm.kt
View file @
e3e6430d
...
@@ -14,10 +14,7 @@ actual abstract class RefCnt : Managed {
...
@@ -14,10 +14,7 @@ actual abstract class RefCnt : Managed {
Reference
.
reachabilityFence
(
this
)
Reference
.
reachabilityFence
(
this
)
}
}
override
fun
toString
():
String
{
override
fun
toString
()
=
refCntToString
(
super
.
toString
(),
0L
)
val
s
=
super
.
toString
()
return
s
.
substring
(
0
,
s
.
length
-
1
)
+
", refCount="
+
refCount
+
")"
}
private
object
_FinalizerHolder
{
private
object
_FinalizerHolder
{
val
PTR
=
_nGetFinalizer
()
val
PTR
=
_nGetFinalizer
()
...
...
skiko/src/nativeMain/kotlin/org/jetbrains/skia/impl/RefCnt.native.kt
View file @
e3e6430d
...
@@ -14,10 +14,7 @@ actual abstract class RefCnt : Managed {
...
@@ -14,10 +14,7 @@ actual abstract class RefCnt : Managed {
reachabilityBarrier
(
this
)
reachabilityBarrier
(
this
)
}
}
override
fun
toString
():
String
{
override
fun
toString
()
=
refCntToString
(
super
.
toString
(),
NullPointer
)
val
s
=
super
.
toString
()
return
s
.
substring
(
0
,
s
.
length
-
1
)
+
", refCount="
+
refCount
+
")"
}
private
object
_FinalizerHolder
{
private
object
_FinalizerHolder
{
val
PTR
=
RefCnt_nGetFinalizer
()
val
PTR
=
RefCnt_nGetFinalizer
()
...
...
skiko/src/webMain/kotlin/org/jetbrains/skia/impl/RefCnt.js.kt
View file @
e3e6430d
...
@@ -12,10 +12,7 @@ actual abstract class RefCnt : Managed {
...
@@ -12,10 +12,7 @@ actual abstract class RefCnt : Managed {
return
_nGetRefCount
(
_ptr
)
return
_nGetRefCount
(
_ptr
)
}
}
override
fun
toString
():
String
{
override
fun
toString
()
=
refCntToString
(
super
.
toString
(),
0
)
val
s
=
super
.
toString
()
return
s
.
substring
(
0
,
s
.
length
-
1
)
+
", refCount="
+
refCount
+
")"
}
}
}
private
object
_FinalizerHolder
{
private
object
_FinalizerHolder
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment