Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
D
devcontainer-features
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
eazydevelop-devcontainer-temp
devcontainer-features
Commits
9366ef7e
Unverified
Commit
9366ef7e
authored
Oct 28, 2022
by
Samruddhi Khandale
Committed by
GitHub
Oct 28, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Node: Fix failure when `version:none` (#247)
fix version:none
parent
f1c981d0
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
23 additions
and
1 deletion
+23
-1
devcontainer-feature.json
src/node/devcontainer-feature.json
+1
-1
install.sh
src/node/install.sh
+1
-0
scenarios.json
test/node/scenarios.json
+9
-0
version_none.sh
test/node/version_none.sh
+12
-0
No files found.
src/node/devcontainer-feature.json
View file @
9366ef7e
{
{
"id"
:
"node"
,
"id"
:
"node"
,
"version"
:
"1.1.
0
"
,
"version"
:
"1.1.
1
"
,
"name"
:
"Node.js (via nvm) and yarn"
,
"name"
:
"Node.js (via nvm) and yarn"
,
"documentationURL"
:
"https://github.com/devcontainers/features/tree/main/src/node"
,
"documentationURL"
:
"https://github.com/devcontainers/features/tree/main/src/node"
,
"description"
:
"Installs Node.js, nvm, yarn, and needed dependencies."
,
"description"
:
"Installs Node.js, nvm, yarn, and needed dependencies."
,
...
...
src/node/install.sh
View file @
9366ef7e
...
@@ -205,6 +205,7 @@ rm -rf /var/lib/apt/lists/*
...
@@ -205,6 +205,7 @@ rm -rf /var/lib/apt/lists/*
# Ensure privs are correct for installed node versions. Unfortunately the
# Ensure privs are correct for installed node versions. Unfortunately the
# way nvm installs node versions pulls privs from the tar which does not
# way nvm installs node versions pulls privs from the tar which does not
# have group write set. We need this when the gid/uid is updated.
# have group write set. We need this when the gid/uid is updated.
mkdir
-p
"
${
NVM_DIR
}
/versions"
chmod
-R
g+rw
"
${
NVM_DIR
}
/versions"
chmod
-R
g+rw
"
${
NVM_DIR
}
/versions"
echo
"Done!"
echo
"Done!"
test/node/scenarios.json
View file @
9366ef7e
...
@@ -16,5 +16,14 @@
...
@@ -16,5 +16,14 @@
"version"
:
"latest"
"version"
:
"latest"
}
}
}
}
},
"version_none"
:
{
"image"
:
"mcr.microsoft.com/devcontainers/base"
,
"remoteUser"
:
"vscode"
,
"features"
:
{
"node"
:
{
"version"
:
"none"
}
}
}
}
}
}
\ No newline at end of file
test/node/version_none.sh
0 → 100755
View file @
9366ef7e
#!/bin/bash
set
-e
# Optional: Import test library
source
dev-container-features-test-lib
# Definition specific tests
check
"nvm"
bash
-c
". /usr/local/share/nvm/nvm.sh && nvm install 10"
# Report result
reportResults
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment